[webkit-reviews] review granted: [Bug 49481] Implement WebKit Full Screen support : [Attachment 78136] NewFullScreen-Part-3-Renderering

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 49481: Implement WebKit Full Screen support
https://bugs.webkit.org/show_bug.cgi?id=49481

Attachment 78136: NewFullScreen-Part-3-Renderering
https://bugs.webkit.org/attachment.cgi?id=78136&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78136&action=review

> WebCore/page/FrameView.cpp:529
> +static bool isDocumentRunningFullScreenAnimation(Document* document)

Since the param makes it obvious this applies to a Document,
isRunningFullScreenAnimation(Document*) is better I think.

> WebCore/page/FrameView.cpp:646
> +    // The fullScreenRenderer's graphicsLayer  has been re-parented, and the
above recursive syncCompositingState

Double space between graphicsLayer and has.

> WebCore/rendering/RenderFullScreen.cpp:36
> -	   layer()->rendererContentChanged();
> +	   layer()->contentChanged(RenderLayer::VideoChanged);

I can't see enough context to know if this is an appropriate change.