[webkit-reviews] review requested: [Bug 26276] Need a mechanism to determine stack extent on WINDOWS, SOLARIS, OPENBSD, SYMBIAN, HAIKU, WINCE platforms : [Attachment 78133] Patch for WinCE (with detectGrowingDownward)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 6 11:18:47 PST 2011


Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 26276: Need a mechanism to determine stack extent on WINDOWS, SOLARIS,
OPENBSD, SYMBIAN, HAIKU, WINCE platforms
https://bugs.webkit.org/show_bug.cgi?id=26276

Attachment 78133: Patch for WinCE (with detectGrowingDownward)
https://bugs.webkit.org/attachment.cgi?id=78133&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
Can you please r+ this patch?
It only added the required detectGrowingDownward function.

Diff to the already reviewed patch:

+static bool detectGrowingDownward(void* previousFrame)
+{
+    // Find the address of this stack frame by taking the address of a local
variable.
+    int thisFrame;
+    return previousFrame > &thisFrame;
+}
+


More information about the webkit-reviews mailing list