[webkit-reviews] review granted: [Bug 51231] document.querySelector(':nth-child(foo)') should throw a syntax error : [Attachment 78110] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 51231: document.querySelector(':nth-child(foo)') should throw a syntax
error
https://bugs.webkit.org/show_bug.cgi?id=51231

Attachment 78110: Patch
https://bugs.webkit.org/attachment.cgi?id=78110&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78110&action=review

> WebCore/css/CSSGrammar.y:1212
> +	       }
> +	       else

WebKit project style is to put the else on the same line as the close brace.

> WebCore/css/CSSParser.h:82
> +	   bool isValidNthToken(const CSSParserString&);

This should be a static member function. There is no dependency here on the
parser state, so no need for a non-static member function.