[webkit-reviews] review granted: [Bug 51710] [chromium] Add a WebAutoFillClient interface that moves some functions from WebViewClient : [Attachment 77820] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 5 22:49:31 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted John
Abd-El-Malek <jam at chromium.org>'s request for review:
Bug 51710: [chromium] Add a WebAutoFillClient interface that moves some
functions from WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=51710

Attachment 77820: Patch
https://bugs.webkit.org/attachment.cgi?id=77820&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77820&action=review

This patch is a good incremental improvement.  Long term, I would like us to
move most of the auto-fill / auto-complete logic out of WebKit and instead
provide lower level, generic APIs to access the information and events that we
need in order to support having the implementation live in chromium.  Generic
APIs are usually better since they can be used to support other features in the
future.

> WebKit/chromium/public/WebAutoFillClient.h:46
> +    virtual void queryAutoFillSuggestions(const WebNode&,

nit: it would be helpful to document what the callee is supposed to do in
response to this method.
i assume the embedder is supposed to call some other function to pass results
back to WebKit.
(i think the method is WebView::applyAutoFillSuggestions.)


More information about the webkit-reviews mailing list