[webkit-reviews] review granted: [Bug 46990] TypedArray - NaNs converted to 0 in Float32 array : [Attachment 77946] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 46990: TypedArray - NaNs converted to 0 in Float32 array
https://bugs.webkit.org/show_bug.cgi?id=46990

Attachment 77946: Patch
https://bugs.webkit.org/attachment.cgi?id=77946&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77946&action=review

Looks good overall; one question. If there's an error in the test, just feel
free to fix it upon landing the patch.

> LayoutTests/fast/canvas/webgl/array-unit-tests.html:618
> +	 for (var i = 1; i < array.length; ++i)

Did you mean to start this iteration at 1?

> LayoutTests/fast/canvas/webgl/array-unit-tests.html:622
> +	 for (var i = 1; i < array.length; ++i)

Same question here.