[webkit-reviews] review granted: [Bug 51952] Implement mozilla's animationTime property : [Attachment 78058] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 51952: Implement mozilla's animationTime property
https://bugs.webkit.org/show_bug.cgi?id=51952

Attachment 78058: Patch
https://bugs.webkit.org/attachment.cgi?id=78058&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78058&action=review

r=me, but think about the WebHTMLView changes.

> WebKit/mac/WebView/WebHTMLView.mm:3512
> +    Frame* frame = [webView _mainCoreFrame];
> +    if (frame && frame->page())
> +	   frame->page()->animationTime()->clearCurrentAnimationTime();
> +    

Is it correct to call clearCurrentAnimationTime() for each subframe?

You may also want to think about whether it's appropriate to call this for
printing, and when views are being snapshotted.

You should make this work in WebKit2 as well.