[webkit-reviews] review granted: [Bug 51424] Add WebKitClient::createAudioDevice() for Chromium port of web audio API : [Attachment 77165] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 51424: Add WebKitClient::createAudioDevice() for Chromium port of web audio
API
https://bugs.webkit.org/show_bug.cgi?id=51424

Attachment 77165: Patch
https://bugs.webkit.org/attachment.cgi?id=77165&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77165&action=review

> WebKit/chromium/src/AudioDestinationChromium.cpp:47
> +const unsigned CallbackBufferSize = 2048;

I'm pretty sure the preferred style for constants is to use variableNaming
style.

> WebKit/chromium/src/AudioDestinationChromium.cpp:105
> +    if (!isNumberOfChannelsGood)

nit: instead of repeating the expression, use ASSERT_NOT_REACHED if the branch
is taken.

> WebKit/chromium/src/AudioDestinationChromium.cpp:110
> +    if (!isBufferSizeGood)

ditto