[webkit-reviews] review granted: [Bug 51956] [chromium] refactor complex text on Linux : [Attachment 78046] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 5 14:39:24 PST 2011
David Levin <levin at chromium.org> has granted Evan Martin <evan at chromium.org>'s
request for review:
Bug 51956: [chromium] refactor complex text on Linux
https://bugs.webkit.org/show_bug.cgi?id=51956
Attachment 78046: Patch
https://bugs.webkit.org/attachment.cgi?id=78046&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78046&action=review
PLs consider addressing the nits noted.
> WebCore/platform/graphics/chromium/ComplexTextControllerLinux.h:34
> +#include "Font.h"
Can't you just get by with fwd decls for Font, FontPlatformData,
SimpleFontData, TextRun?
> WebCore/platform/graphics/chromium/ComplexTextControllerLinux.h:37
> +#include <wtf/OwnArrayPtr.h>
missing include for OwnPtr.
More information about the webkit-reviews
mailing list