[webkit-reviews] review granted: [Bug 51943] Implement word transformation : [Attachment 78029] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 51943: Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943

Attachment 78029: Patch
https://bugs.webkit.org/attachment.cgi?id=78029&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78029&action=review

> WebKit2/UIProcess/mac/TextCheckerMac.mm:176
> +    static bool readSmartInsertDeleteEnabledDefault = false;

= false not necessary.	Can't you just do:

static bool smartInsertDeleteEnabled = [[NSUserDefaults standardUserDefaults]
boolForKey:WebSmartInsertDeleteEnabled];
return smartInsertDeleteEnabled;

> WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:73
> +    // FIXME: Why isn't this Mac specific like
toggleSmartInsertDeleteEnabled?

I think we enable it on Windows all the time, but some ports want to turn it
off.