[webkit-reviews] review granted: [Bug 51931] Keep track of active text substitution preferences : [Attachment 78013] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 5 10:17:53 PST 2011


mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 51931: Keep track of active text substitution preferences
https://bugs.webkit.org/show_bug.cgi?id=51931

Attachment 78013: Patch
https://bugs.webkit.org/attachment.cgi?id=78013&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=78013&action=review

> WebKit2/UIProcess/API/mac/WKView.mm:544
> +    if (flag == TextChecker::state().isAutomaticDashSubstitutionEnabled)

Is it safe to compare a BOOL with a bool like this?


More information about the webkit-reviews mailing list