[webkit-reviews] review denied: [Bug 51811] Merge m_height and m_width members of ImageData into a common m_size member : [Attachment 78000] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 5 09:40:34 PST 2011


Dirk Schulze <krit at webkit.org> has denied Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 51811: Merge m_height and m_width members of ImageData into a common m_size
member
https://bugs.webkit.org/show_bug.cgi?id=51811

Attachment 78000: Patch
https://bugs.webkit.org/attachment.cgi?id=78000&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
The rule is, that we always fix style errors within a patch, sorry I can't r+
this patch as is. Please fix the PassRefPtr before uploading a new patch. Just
switch to RefPtr<ImageData>on both files. Make sure that every return value on
ImageBufferHaiku::getImageData() has a release() call: return result.release();


More information about the webkit-reviews mailing list