[webkit-reviews] review denied: [Bug 51330] [Qt] Improve the readability of FrameLoaderClientQt::createPlugin() : [Attachment 77751] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 51330: [Qt] Improve the readability of FrameLoaderClientQt::createPlugin()
https://bugs.webkit.org/show_bug.cgi?id=51330

Attachment 77751: Patch
https://bugs.webkit.org/attachment.cgi?id=77751&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77751&action=review

> WebKit/qt/tests/qwebpluginfactory/tst_qwebpluginfactory.cpp:2
> + * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)

Wrong year. ;)

> WebKit/qt/tests/qwebpluginfactory/tst_qwebpluginfactory.cpp:144
> +    QVERIFY(plugins.size() == 1);

Please use QCOMPARE() instead where it makes sense.
The output will be a lot more readable when/if something starts failing.