[webkit-reviews] review denied: [Bug 43704] Web font is printed as blank if it is not cached : [Attachment 75770] Renamed the cache validation suppression bit
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 5 06:46:59 PST 2011
Antti Koivisto <koivisto at iki.fi> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 43704: Web font is printed as blank if it is not cached
https://bugs.webkit.org/show_bug.cgi?id=43704
Attachment 75770: Renamed the cache validation suppression bit
https://bugs.webkit.org/attachment.cgi?id=75770&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Why does it try to reload resources when switching to printing?
Why can't you use the existing m_allowStaleResources? A separate
m_allowStaleResourcesWithinDocument doesn't make that much sense as
CachedResourceLoader is per-document anyway.
You need to make a new patch, the code you are modifying has changed
substantially, r- for now.
More information about the webkit-reviews
mailing list