[webkit-reviews] review requested: [Bug 45423] [Gtk] Port tiled backing store : [Attachment 77979] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 5 00:40:07 PST 2011


Joone Hur <joone at kldp.org> has asked  for review:
Bug 45423: [Gtk] Port tiled backing store
https://bugs.webkit.org/show_bug.cgi?id=45423

Attachment 77979: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=77979&action=review

------- Additional Comments from Joone Hur <joone at kldp.org>
WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:437
> > +	 notImplemented();
> 
> Is this really notImplemented() or is it an empty implementation? There's a
subtle difference.

This callback can be called when m_deletegatesScrolling of the ScrollView is
true, but this value is false by default.
m_deletegatesScrolling can be set to true value in QWebKit, so we don't need to
implement this function in WebKitGtk+.


More information about the webkit-reviews mailing list