[webkit-reviews] review denied: [Bug 51695] check-webkit-style treated some macros with parentheses after #elif as function calls : [Attachment 77947] proposed patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Koan-Sin Tan
<koansin.tan at gmail.com>'s request for review:
Bug 51695: check-webkit-style treated some macros with parentheses after #elif
as function calls
https://bugs.webkit.org/show_bug.cgi?id=51695

Attachment 77947: proposed patch
https://bugs.webkit.org/attachment.cgi?id=77947&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Really close!

It looks good but it needs a simple test to verify it. See cpp_unittest.py.
Look for the error "Extra space before (" to see where similar tests are and
add one which verifies that you don't get the error for the false positive
(#elif if I remember correctly).

Run the test using "test-webkitpy" to verify that your test passes.