[webkit-reviews] review requested: [Bug 51903] Tell UI process which subframe is largest : [Attachment 77938] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 15:40:08 PST 2011


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 51903: Tell UI process which subframe is largest
https://bugs.webkit.org/show_bug.cgi?id=51903

Attachment 77938: proposed patch
https://bugs.webkit.org/attachment.cgi?id=77938&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Some potential areas of concern:
- Is the algorithm what clients want? I reinvented it.
- There is no strong guarantee that new data members will be cleared up when
frame tree changes. As far as I can tell, WebFrame classes on both sides will
not be too upset, but I can't be sure.


More information about the webkit-reviews mailing list