[webkit-reviews] review granted: [Bug 51896] Send over text checker state to the web process : [Attachment 77932] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 51896: Send over text checker state to the web process
https://bugs.webkit.org/show_bug.cgi?id=51896

Attachment 77932: Patch
https://bugs.webkit.org/attachment.cgi?id=77932&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77932&action=review

Do you need to update WebKit2.pro?

r=me if you fix these issues.

> WebKit2/UIProcess/mac/TextCheckerMac.mm:36
> +TextCheckerState textCheckerState;

Will this cause a static constructor to be called?

> WebKit2/UIProcess/mac/TextCheckerMac.mm:39
> +static void initializeState() {
> +    static bool didInitializeState = false;

{ on the wrong line.  I believe the = false is unnecessary.