[webkit-reviews] review granted: [Bug 51723] Avoid manual ref/deref in AsyncScriptRunner by using PendingScript : [Attachment 77908] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 12:59:43 PST 2011


Ryosuke Niwa <rniwa at webkit.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 51723: Avoid manual ref/deref in AsyncScriptRunner by using PendingScript
https://bugs.webkit.org/show_bug.cgi?id=51723

Attachment 77908: Patch
https://bugs.webkit.org/attachment.cgi?id=77908&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #7)
> > releaseElementAndClear and ScriptElement::execute BOTH calls
m_cachedScript->removeClient().  Are you sure we want to do this?
> 
> Yes, they are different clients. releaseElementAndClear removes the
PendingScript client and execute removes the ScriptElement client.

OK, now I see it. r=me.


More information about the webkit-reviews mailing list