[webkit-reviews] review requested: [Bug 51889] WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use WebCore::PluginInfo.name : [Attachment 77917] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 12:36:52 PST 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 51889: WebFrameLoaderClient::createMediaPlayerProxyPlugin() should use
WebCore::PluginInfo.name
https://bugs.webkit.org/show_bug.cgi?id=51889

Attachment 77917: Patch
https://bugs.webkit.org/attachment.cgi?id=77917&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

This originally broke in r61581.  It is inside an
ENABLE(PLUGIN_PROXY_FOR_VIDEO) macro, so it didn't break the Mac
build then.

* WebCoreSupport/WebFrameLoaderClient.mm: Call
(WebFrameLoaderClient::createMediaPlayerProxyPlugin): Updated to
use WebCore::PluginInfo.name instead of
-[WebBasePluginPackage name].
---
 2 files changed, 16 insertions(+), 1 deletions(-)


More information about the webkit-reviews mailing list