[webkit-reviews] review granted: [Bug 51886] Add more spelling/grammar related methods : [Attachment 77910] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 11:39:38 PST 2011


John Sullivan <sullivan at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 51886: Add more spelling/grammar related methods
https://bugs.webkit.org/show_bug.cgi?id=51886

Attachment 77910: Patch
https://bugs.webkit.org/attachment.cgi?id=77910&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77910&action=review

> WebKit2/UIProcess/API/mac/WKView.mm:57
> +// FIXME: <rdar://problem/8728860> WebKit2 needs to be localized

It would help us track down remaining WebKit2 work if you used the format: //
FIXME (WebKit2) <etc>

> WebKit2/UIProcess/API/mac/WKView.mm:417
> +    // FIXME: <rdar://problem/8245958> Make Spelling/Grammar checking work
in WebKit2

Same here.

> WebKit2/UIProcess/API/mac/WKView.mm:422
> +    // FIXME: <rdar://problem/8245958> Make Spelling/Grammar checking work
in WebKit2

Same here.

> WebKit2/WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:43
> +// FIXME: <rdar://problem/8728860> WebKit2 needs to be localized

Same here.


More information about the webkit-reviews mailing list