[webkit-reviews] review requested: [Bug 51249] [Qt] Extend the Platform Plugin to support full screen video handler : [Attachment 77888] updated with Ariya's suggestion

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 08:12:17 PST 2011


yi shen <yi.4.shen at nokia.com> has asked  for review:
Bug 51249: [Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249

Attachment 77888: updated with Ariya's suggestion
https://bugs.webkit.org/attachment.cgi?id=77888&action=review

------- Additional Comments from yi shen <yi.4.shen at nokia.com>
I got one error when running the check-webkit-style,
WebKit/qt/WebCoreSupport/FullscreenVideoQt.h:50:  The parameter name "node"
adds no information, so it should be removed.  [readability/parameter_name] [5]


50    MediaPlayerPrivateQt* mediaPlayerForNode(Node* node = 0);

Seems it is a bug in the check-webkit-style script.


More information about the webkit-reviews mailing list