[webkit-reviews] review granted: [Bug 51811] Merge m_height and m_width members of ImageData into a common m_size member : [Attachment 77885] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 51811: Merge m_height and m_width members of ImageData into a common m_size
member
https://bugs.webkit.org/show_bug.cgi?id=51811

Attachment 77885: Patch
https://bugs.webkit.org/attachment.cgi?id=77885&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77885&action=review

Getting better, but not quite there yet.

There are a bunch of ImageData::create() calls in WebCore, for example in
FilterEffect. They should be updated to pass an IntSize now (does this patch
even build?)

> WebCore/html/ImageData.h:43
> +    static PassRefPtr<ImageData> create(IntSize);
> +    static PassRefPtr<ImageData> create(IntSize, PassRefPtr<ByteArray>);

IntSize -> const IntSize&

> WebCore/html/ImageData.h:52
> +    ImageData(IntSize);
> +    ImageData(IntSize, PassRefPtr<ByteArray>);

IntSize -> const IntSize&

> WebCore/html/canvas/CanvasRenderingContext2D.cpp:1532
> +    IntSize size(imageData->size());
>      return createEmptyImageData(size);

No need for the temporary "size" variable here.