[webkit-reviews] review denied: [Bug 51764] [GTK] Port stock icon painting to GtkStyleContext : [Attachment 77798] Updated patch using Page::scheduleForcedStyleRecalcForAllPages()

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 51764: [GTK] Port stock icon painting to GtkStyleContext
https://bugs.webkit.org/show_bug.cgi?id=51764

Attachment 77798: Updated patch using
Page::scheduleForcedStyleRecalcForAllPages()
https://bugs.webkit.org/attachment.cgi?id=77798&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77798&action=review

r- in case we can avoid searching twice.

> WebCore/platform/gtk/RenderThemeGtk3.cpp:85
> +

GtkWidgetPath could possibly be added to our GOwnPtr stuff at some point.

> WebCore/platform/gtk/RenderThemeGtk3.cpp:91
> +    return iter->second.get();

Instead of doing contains() + find() I think you could just do one find() and
then check that the iter is valid. Seems pointless to search twice?