[webkit-reviews] review denied: [Bug 51863] [chromium] WEBKIT_API and styling fixes for the chromium api. : [Attachment 77864] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 00:57:51 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 51863: [chromium] WEBKIT_API and styling fixes for the chromium api.
https://bugs.webkit.org/show_bug.cgi?id=51863

Attachment 77864: Patch
https://bugs.webkit.org/attachment.cgi?id=77864&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77864&action=review

> WebKit/chromium/public/WebDOMEventListener.h:51
> +    virtual ~WebDOMEventListener();

this will break the build.  because the implementation is provided by
a .cpp file and callable by chromium, it needs to be marked WEBKIT_API.

it is rather unusual for us to have virtual destructors in the API like
this.  the destructor needs to be virtual because this is an interface
meant to be subclassed.  to keep the rules simple, we could just have
this be implemented inline to a private method, and then that private
method would be marked WEBKIT_API.


More information about the webkit-reviews mailing list