[webkit-reviews] review denied: [Bug 36279] CSS3 :nth-child selector and valid whitespace test fails : [Attachment 77859] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 3 21:39:25 PST 2011


Darin Adler <darin at apple.com> has denied  review:
Bug 36279: CSS3 :nth-child selector and valid whitespace test fails
https://bugs.webkit.org/show_bug.cgi?id=36279

Attachment 77859: Patch
https://bugs.webkit.org/attachment.cgi?id=77859&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Changing the tokenizer but not updating CSSSelector::RareData::parseNth is not
going to work correctly. It seems the test case here was insufficient to detect
that. Please work on a patch that changes both the tokenizer and the parser to
allow spaces!


More information about the webkit-reviews mailing list