[webkit-reviews] review requested: [Bug 29674] meta http-equiv Refresh is not honored when 'space' instead of semicolon is used. : [Attachment 77852] updated with new tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 3 16:40:24 PST 2011


Roger Scott <roger.scott at nokia.com> has asked  for review:
Bug 29674: meta http-equiv Refresh is not honored when 'space' instead of
semicolon is used.
https://bugs.webkit.org/show_bug.cgi?id=29674

Attachment 77852: updated with new tests
https://bugs.webkit.org/attachment.cgi?id=77852&action=review

------- Additional Comments from Roger Scott <roger.scott at nokia.com>
I added check of return value from skipWhiteSpace that Jungshik was going to
add,
and removed the redundant "check for the space".

Also introduced new technique, as requested by Darin, to support adding many
more tests for the parser.  
I refresh/redirect to same php file for each test, using cookies for state.
Final test must redirect to "success" html 
or there was a failure. More tests can be easily added.  
I included relevant tests that exist singly in other files: if this technique
is acceptable I could remove the other single test
files so that all refresh parser tests are in one place.


More information about the webkit-reviews mailing list