[webkit-reviews] review requested: [Bug 48781] Add a resourceload delegate method to query if WebCore should paint the default broken image for failed images. : [Attachment 77846] New patch addressing comments.

[bugzilla-daemon at webkit.org]

Yongjun Zhang <yongjun_zhang at apple.com> has asked  for review:
Bug 48781: Add a resourceload delegate method to query if WebCore should paint
the default broken image for failed images.
https://bugs.webkit.org/show_bug.cgi?id=48781

Attachment 77846: New patch addressing comments.
https://bugs.webkit.org/attachment.cgi?id=77846&action=review

------- Additional Comments from Yongjun Zhang <yongjun_zhang at apple.com>
Thanks, for the review.  Here is the new patch.

Changes:

1. added default implementation for FrameLoaderClient::shouldPaintBrokenImage,
so that I don't need to touch other WebKit ports.
2. set m_shouldPaintBrokenImage in CachedImage::checkShouldPaintBrokenImage
instead of the call site.
3. moved webView:shouldPaintBrokenImage:(NSURL*)imageURL to
WebResourceLoadDelegatePrivate.
4. removed image errorcode argument from
FrameLoaderClient::shouldPaintBrokenImage and the delegate method, since the
developer asked for this feature mainly cared about the URL of the failed
image, no the error code.  I will open another bug if they really need it.