[webkit-reviews] review denied: [Bug 51818] GeolocationPositionCache should not use ScriptExecutionContext::Task : [Attachment 77844] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 3 14:00:27 PST 2011


David Levin <levin at chromium.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 51818: GeolocationPositionCache should not use ScriptExecutionContext::Task
https://bugs.webkit.org/show_bug.cgi?id=51818

Attachment 77844: Patch
https://bugs.webkit.org/attachment.cgi?id=77844&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77844&action=review

> WebCore/page/GeolocationPositionCache.cpp:46
> +class CacheTask : public Task {

I don't think you need this stuff.

Instead FileThreadTask.h should only rely on Task now and could be moved to wtf
with Task.


More information about the webkit-reviews mailing list