[webkit-reviews] review granted: [Bug 51368] [Web Timing] requestStart and responseStart should be available even if the document is still loading : [Attachment 77062] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 3 13:45:23 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 51368: [Web Timing] requestStart and responseStart should be available even
if the document is still loading
https://bugs.webkit.org/show_bug.cgi?id=51368

Attachment 77062: Patch
https://bugs.webkit.org/attachment.cgi?id=77062&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77062&action=review

Otherwise, LGTM

> WebCore/page/PerformanceTiming.cpp:36
> +#include "CurrentTime.h"

I think it is more conventional to include files from WTF using the notation:

 #include <wtf/CurrentTime.h>

At least, that's what I see being done in WebCore.


More information about the webkit-reviews mailing list