[webkit-reviews] review granted: [Bug 51847] Shrink RootInlineBox : [Attachment 77839] Roll m_baselineType into a bitfield

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 3 13:24:45 PST 2011


Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 51847: Shrink RootInlineBox
https://bugs.webkit.org/show_bug.cgi?id=51847

Attachment 77839: Roll m_baselineType into a bitfield
https://bugs.webkit.org/attachment.cgi?id=77839&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Did you test whether this works properly on Windows? I seem to recall that on
Windows bitfields are signed so the 1 value ends up being -1. Sometimes we have
to use the type unsigned instead of the actual enum type to work around that.
r=m if this doesn't break with MSVC.


More information about the webkit-reviews mailing list