[webkit-reviews] review granted: [Bug 28152] Implement -webkit-linear-gradient and -webkit-radial-gradient : [Attachment 77782] Add radial-gradient support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 3 10:59:37 PST 2011


Dave Hyatt <hyatt at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 28152: Implement -webkit-linear-gradient and -webkit-radial-gradient
https://bugs.webkit.org/show_bug.cgi?id=28152

Attachment 77782: Add radial-gradient support
https://bugs.webkit.org/attachment.cgi?id=77782&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77782&action=review

Make sure to communicate to webkit-dev so that ports know they need to update
gradient code.

> WebCore/css/CSSGradientValue.cpp:229
> +    if (numStops > 1 && (stops[0].offset < 0 || stops[numStops - 1].offset >
1)) {

Extra blank line after this if opens that you can get rid of.


More information about the webkit-reviews mailing list