[webkit-reviews] review requested: [Bug 50331] ASSERT failing restoring scroll position from HistoryItem after reload : [Attachment 77812] Patch proposal + unit test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 3 09:33:35 PST 2011


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 50331: ASSERT failing restoring scroll position from HistoryItem after
reload
https://bugs.webkit.org/show_bug.cgi?id=50331

Attachment 77812: Patch proposal + unit test
https://bugs.webkit.org/attachment.cgi?id=77812&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching new patch to be reviewed, this time moving the null check to
HistoryController::restoreScrollPositionAndViewState(), that is, removing the
ASSERT and explaining the change in a comment :P

Also, provided the unit test as in the previous patch


More information about the webkit-reviews mailing list