[webkit-reviews] review denied: [Bug 50174] Get rid of prefix header dependency for WebKit2 build system : [Attachment 77351] Adding config.h to every WebKit2 cpp file.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 3 09:13:31 PST 2011
David Levin <levin at chromium.org> has denied Greg <greg.coletta at nokia.com>'s
request for review:
Bug 50174: Get rid of prefix header dependency for WebKit2 build system
https://bugs.webkit.org/show_bug.cgi?id=50174
Attachment 77351: Adding config.h to every WebKit2 cpp file.
https://bugs.webkit.org/attachment.cgi?id=77351&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77351&action=review
r- because this breaks some builds.
Also, does this change have consensus with the folks working on WebKit2? This
seems like it should be resolved on webkit-dev (rather than a bug/patch).
> Tools/Scripts/webkitpy/style/checker.py:161
> + # Certain directories have other idiosyncracies.
Nit: "other" would no longer apply here.
More information about the webkit-reviews
mailing list