[webkit-reviews] review denied: [Bug 51750] [Qt]Add local storage settings to QtTestBrowser command line arguments : [Attachment 77808] Patch to enable local storage settings from command line in QtTestBrowser

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied suchi <suchi.kundu at nokia.com>'s
request for review:
Bug 51750: [Qt]Add local storage settings to QtTestBrowser command line
arguments
https://bugs.webkit.org/show_bug.cgi?id=51750

Attachment 77808: Patch to enable local storage settings from command line in
QtTestBrowser
https://bugs.webkit.org/attachment.cgi?id=77808&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77808&action=review

> WebKit.pri:68
> -linux-g++* {
> -    isEqual(QT_ARCH,x86_64)|isEqual(QT_ARCH,i386): QMAKE_CXXFLAGS += -Werror

> -}
> +#linux-g++* {isEqual(QT_ARCH,x86_64)|isEqual(QT_ARCH,i386): QMAKE_CXXFLAGS
+= -Werror}

This does not belong in this patch.

> WebKitTools/QtTestBrowser/main.cpp:79
> -    QWebSettings::enablePersistentStorage();
> +    QWebSettings::enablePersistentStorage();    

Unrelated whitespace change.

> WebKitTools/QtTestBrowser/main.cpp:132
> +		<< "[-localStorageEnabled]"
> +		<< "[-offlineStorageDatabaseEnabled]"
> +		<< "[-offlineWebApplicationCacheEnabled]"
> +		<< "[-setOfflineStorageDefaultQuota maxSize]"

You should follow the same convention as the existing options,
-words-separated-by-dashes

> WebKitTools/QtTestBrowser/main.cpp:168
> +    if (args.contains("-localStorageEnabled")) {
> +	  
QWebSettings::globalSettings()->setAttribute(QWebSettings::LocalStorageEnabled,
true);
> +    }

Coding style, no {} here.

> WebKitTools/QtTestBrowser/main.cpp:172
> +    if (args.contains("-offlineStorageDatabaseEnabled")) {
> +	  
QWebSettings::globalSettings()->setAttribute(QWebSettings::OfflineStorageDataba
seEnabled, true);
> +    }

Ditto.

> WebKitTools/QtTestBrowser/main.cpp:176
> +    if (args.contains("-offlineWebApplicationCacheEnabled")) {
> +	  
QWebSettings::globalSettings()->setAttribute(QWebSettings::OfflineWebApplicatio
nCacheEnabled, true);
> +    }

Ditto.

> WebKitTools/QtTestBrowser/main.cpp:179
> +    if (setOfflineStorageDefaultQuotaIndex != -1){

Coding style, space between ) and {.

> WebKitTools/QtTestBrowser/webpage.cpp:50
> -    applyProxy();
> -
> +    applyProxy();	
> +	   

Unrelated whitespace change.