[webkit-reviews] review granted: [Bug 48957] [Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge : [Attachment 75941] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 48957: [Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge
https://bugs.webkit.org/show_bug.cgi?id=48957

Attachment 75941: Patch
https://bugs.webkit.org/attachment.cgi?id=75941&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=75941&action=review

> WebCore/bridge/qt/qt_runtime.cpp:137
> +// this is here as a proxy, so we'd have a class to friend in QDRTNode,

Capital T.

> WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:91
> +	   m_node = static_cast<Node*>(node);

Do you need to static_cast Node* to Node*?