[webkit-reviews] review granted: [Bug 51791] Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming : [Attachment 77789] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 2 20:45:11 PST 2011
Kent Tamura <tkent at chromium.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 51791: Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input
refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791
Attachment 77789: Patch
https://bugs.webkit.org/attachment.cgi?id=77789&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77789&action=review
Great!
> WebCore/html/BaseTextInputType.h:43
> +private:
nit: Should have a blank line before private:
> WebCore/html/ImageInputType.cpp:100
> + image->updateAltText();
nit: wrong indentation.
More information about the webkit-reviews
mailing list