[webkit-reviews] review requested: [Bug 51601] WML Parser should treat line/column number in a consistent way : [Attachment 77785] Proposed Patch4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 2 17:16:05 PST 2011
Joone Hur <joone at kldp.org> has asked for review:
Bug 51601: WML Parser should treat line/column number in a consistent way
https://bugs.webkit.org/show_bug.cgi?id=51601
Attachment 77785: Proposed Patch4
https://bugs.webkit.org/attachment.cgi?id=77785&action=review
------- Additional Comments from Joone Hur <joone at kldp.org>
Fixed the DRT test fail.
XML Parser reports only the first parsing error even if there are many errors
on the same line.
However, the latest patch reports all errors on the same line, so I fixed the
patch as follows,
bool operator==(const TextPosition& other) { return m_line == other.m_line &&
m_column == other.m_column; }
bool operator!=(const TextPosition& other) { return !((*this) == other); }
=>
bool operator==(const TextPosition& other) { return m_line == other.m_line &&
m_column == other.m_column; }
bool operator!=(const TextPosition& other) { return m_line != other.m_line &&
m_column != other.m_column; }
More information about the webkit-reviews
mailing list