[webkit-reviews] review granted: [Bug 51802] Move LayoutTestResults over to new-run-webkit-tests TestResult architecture : [Attachment 77778] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 51802: Move LayoutTestResults over to new-run-webkit-tests TestResult
architecture
https://bugs.webkit.org/show_bug.cgi?id=51802

Attachment 77778: Patch
https://bugs.webkit.org/attachment.cgi?id=77778&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77778&action=review

> Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:34
> +from webkitpy.layout_tests.layout_package import test_results
> +from webkitpy.layout_tests.layout_package import test_failures

We should move these classes to common.   Common shouldn't depend on
layout_tests.

> Tools/Scripts/webkitpy/tool/commands/queries.py:275
> -	   chosen_name = User.prompt_with_list("Which builder to diagnose:",
builder_choices)
> +	   chosen_name = self._tool.user.prompt_with_list("Which builder to
diagnose:", builder_choices)

These changes seem separate, but ok.

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:38
> +from webkitpy.layout_tests.layout_package import test_failures
>  from webkitpy.layout_tests.port import factory

Another bad dependency....  :(