[webkit-reviews] review requested: [Bug 26276] Need a mechanism to determine stack extent on WINDOWS, SOLARIS, OPENBSD, SYMBIAN, HAIKU, WINCE platforms : [Attachment 77721] Patch for WinCE

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 2 12:24:11 PST 2011


Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 26276: Need a mechanism to determine stack extent on WINDOWS, SOLARIS,
OPENBSD, SYMBIAN, HAIKU, WINCE platforms
https://bugs.webkit.org/show_bug.cgi?id=26276

Attachment 77721: Patch for WinCE
https://bugs.webkit.org/attachment.cgi?id=77721&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
(In reply to comment #38)
> (From update of attachment 77721 [details])
> Hi Patrick, patch looks great, but r- for the style-bot issues.  Please
resubmit without '\r's & I'll be happy to r+.
> cheers, G.
Ok, now I know the problem: StackBounds.cpp has _no_ svn:eol-style=natvie _and_
CRLF (That's the reason why the second patch does not apply!).
If you r+ I'll commit it manually and add the svn:eol-style property.


More information about the webkit-reviews mailing list