[webkit-reviews] review denied: [Bug 48031] AffineTransform operator* reverses order of operands. : [Attachment 76578] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Shane Stephens
<shanestephens at google.com>'s request for review:
Bug 48031: AffineTransform operator* reverses order of operands.
https://bugs.webkit.org/show_bug.cgi?id=48031

Attachment 76578: Patch
https://bugs.webkit.org/attachment.cgi?id=76578&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76578&action=review

The patch looks good in general, but I'd prefer to use multiply and
postMultiply where ever possible. Another question, would it make sense to
rename multiply with preMultiply corresponding to postMultiply?

r- for the questions above and the wrong comment style.

> WebCore/platform/graphics/transforms/AffineTransform.cpp:170
> +/**
> + * Multiplies this AffineTransform by the provided AffineTransform - i.e.
> + * this = this * other;
> + */

Comments with //