[webkit-reviews] review denied: [Bug 51791] Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input refactoring and renaming : [Attachment 77770] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Darin Adler
<darin at apple.com>'s request for review:
Bug 51791: Eliminate HTMLInputElement::m_deprecatedTypeNumber, other input
refactoring and renaming
https://bugs.webkit.org/show_bug.cgi?id=51791

Attachment 77770: Patch
https://bugs.webkit.org/attachment.cgi?id=77770&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=77770&action=review

This is awesome, long collective work of factoring this out finally coming to a
close. Almost wish we landed this patch in 2010 :)

> WebCore/html/HTMLInputElement.cpp:604
> +	   if (renderer() && renderer()->isRenderImage())

Seems like this could be a flag on the InputType?

> WebCore/html/HTMLInputElement.cpp:-1394
> -bool HTMLInputElement::defaultChecked() const
> -{
> -    return fastHasAttribute(checkedAttr);
> -}
> -

The EWS says that it's used it in
WebKit/chromium/src/WebSearchableFormData.cpp. Can you change the code there to
just query the attribute?

> WebCore/html/InputType.h:75
> +    // Type query functions (try not to use these; bad factoring)

Can you explain a bit more here, maybe indicate future intent of refactoring?