[webkit-reviews] review denied: [Bug 51789] Don't include Inspector headers when Inspector is disabled : [Attachment 77740] Don't include Inspector headers when Inspector is disabled
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 1 08:33:56 PST 2011
Darin Adler <darin at apple.com> has denied Konstantin Tokarev
<annulen at yandex.ru>'s request for review:
Bug 51789: Don't include Inspector headers when Inspector is disabled
https://bugs.webkit.org/show_bug.cgi?id=51789
Attachment 77740: Don't include Inspector headers when Inspector is disabled
https://bugs.webkit.org/attachment.cgi?id=77740&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77740&action=review
> WebCore/bindings/js/JSDOMWindowBase.cpp:34
> +
> +#if ENABLE(INSPECTOR)
> #include "InspectorController.h"
> +#endif
> +
Conditional includes should go in separate paragraphs after the unconditional
includes, not sorted in the middle of the unconditional includes.
More information about the webkit-reviews
mailing list