[webkit-reviews] review granted: [Bug 55425] Teach JavaScriptCore GYP build about DEPTH : [Attachment 84150] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 55425: Teach JavaScriptCore GYP build about DEPTH
https://bugs.webkit.org/show_bug.cgi?id=55425

Attachment 84150: Patch
https://bugs.webkit.org/attachment.cgi?id=84150&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84150&action=review

> Source/JavaScriptCore/gyp/JavaScriptCore.gyp:27
> +	   '<(DEPTH)', # Some paths in API include JavaScriptCore/
> +	   '<(DEPTH)/JavaScriptCore',
> +	   '<(DEPTH)/JavaScriptCore/ForwardingHeaders',
> +	   '<(DEPTH)/JavaScriptCore/API',
> +	   '<(DEPTH)/JavaScriptCore/assembler',
> +	   '<(DEPTH)/JavaScriptCore/collector/handles',
> +	   '<(DEPTH)/JavaScriptCore/bytecode',
> +	   '<(DEPTH)/JavaScriptCore/bytecompiler',
> +	   '<(DEPTH)/JavaScriptCore/debugger',
> +	   '<(DEPTH)/JavaScriptCore/icu',
> +	   '<(DEPTH)/JavaScriptCore/interpreter',
> +	   '<(DEPTH)/JavaScriptCore/jit',
> +	   '<(DEPTH)/JavaScriptCore/parser',
> +	   '<(DEPTH)/JavaScriptCore/profiler',
> +	   '<(DEPTH)/JavaScriptCore/runtime',
> +	   '<(DEPTH)/JavaScriptCore/wtf',
> +	   '<(DEPTH)/JavaScriptCore/wtf/unicode',

This seems annoyingly verbose.	Would be nice to have an INCLUDE_ROOT feature
for gyp. :)