[webkit-reviews] review requested: [Bug 55438] Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject() : [Attachment 84177] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 28 19:45:28 PST 2011
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 55438: Cleanup: Separate port-specific implementation details from
webkitdirs::buildCMakeProject()
https://bugs.webkit.org/show_bug.cgi?id=55438
Attachment 84177: Patch
https://bugs.webkit.org/attachment.cgi?id=84177&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
I am not very familiar with CMake or the EFL and WinCE ports. So, I would
appreciate if this patch is scrutinized for correctness.
I implemented the functionality for cleaning a CMake project (i.e. build-webkit
--clean) using cmake --build ... --target clean. Currently, the code "cleans" a
project by removing the build directory (why?).
More information about the webkit-reviews
mailing list