[webkit-reviews] review granted: [Bug 55442] webarchives don't contain subframe content : [Attachment 84175] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 19:39:26 PST 2011


Gavin Barraclough <barraclough at apple.com> has granted Alice Liu
<alice.liu at apple.com>'s request for review:
Bug 55442: webarchives don't contain subframe content
https://bugs.webkit.org/show_bug.cgi?id=55442

Attachment 84175: patch
https://bugs.webkit.org/attachment.cgi?id=84175&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
r+ since this changes behaviour to match webkit1.  But it seems like
LegacyWebArchive::create should have the same behaviour whether it is passed
the frame or the document I think this is likely either a bug, or a case for a
function to be renamed to make this clearer.  We should probably open a new bug
to track this issue.


More information about the webkit-reviews mailing list