[webkit-reviews] review requested: [Bug 54898] InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle : [Attachment 84163] all-in-one patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 17:43:16 PST 2011


Alice Liu <alice.liu at apple.com> has asked  for review:
Bug 54898: InjectedBundleNodeHandle dies too early in
WKBundleHitTestResultGetNodeHandle
https://bugs.webkit.org/show_bug.cgi?id=54898

Attachment 84163: all-in-one patch
https://bugs.webkit.org/attachment.cgi?id=84163&action=review

------- Additional Comments from Alice Liu <alice.liu at apple.com>
Made a tweak to the test.  changed to use a WKRetainPtr so that the object that
is returned from the (fixed) API call is ref'ed, so that it will crash in
builds where the API call is not fixed.  

also renamed function and other suggestions adam made.


More information about the webkit-reviews mailing list