[webkit-reviews] review denied: [Bug 55430] OwnArrayPtr.=?UTF-8?Q?h=E2=80=99s=20LOOSE=5FOWN=5FARRAY=5FPTR=20mode=20results=20in=20code=20that=20does=20not=20link=20?=: [Attachment 84159] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 17:16:57 PST 2011


Darin Adler <darin at apple.com> has denied Mark Rowe (bdash) <mrowe at apple.com>'s
request for review:
Bug 55430: OwnArrayPtr.h’s LOOSE_OWN_ARRAY_PTR mode results in code that does
not link
https://bugs.webkit.org/show_bug.cgi?id=55430

Attachment 84159: Patch
https://bugs.webkit.org/attachment.cgi?id=84159&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84159&action=review

> Source/JavaScriptCore/wtf/OwnArrayPtr.h:114
> +template<typename T> inline void OwnArrayPtr<T>::set(PtrType ptr)

Needs to be inside an #ifdef.


More information about the webkit-reviews mailing list