[webkit-reviews] review granted: [Bug 26838] Multithread support for JSC on UNIX : [Attachment 84154] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 26838: Multithread support for JSC on UNIX
https://bugs.webkit.org/show_bug.cgi?id=26838

Attachment 84154: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=84154&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=84154&action=review

Okay, with the few fixes I mentioned. This needs to be cleaned up, but the GTK+
bots are dying in a bloody heap at the moment.

> Source/JavaScriptCore/runtime/MachineStackMarker.cpp:74
> +#if USE(PTHREADS)

Please use if !OS(WINDOWS) && !OS(DARWIN) && USE(PTHREADS) here as well.

> Source/JavaScriptCore/runtime/MachineStackMarker.cpp:77
> +#define SA_RESTART 0

Probably should just "#error MachineStackMarker requires SA_RESTART" (or
something nicer sounding) here. I don't think 0 is actually a working
replacement.

> Source/JavaScriptCore/runtime/MachineStackMarker.cpp:124
> +	   struct sigaction act;

act -> action