[webkit-reviews] review granted: [Bug 53744] Number type input cannot be set to empty string if it has an initial value : [Attachment 84148] Patch 2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 53744: Number type input cannot be set to empty string if it has an initial
value
https://bugs.webkit.org/show_bug.cgi?id=53744

Attachment 84148: Patch 2
https://bugs.webkit.org/attachment.cgi?id=84148&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84148&action=review

> Source/WebCore/dom/InputElement.h:120
> +    // represents the emtpy value.

Typo here, “empty”.

> Source/WebCore/html/NumberInputType.cpp:281
> +    return parseToDoubleForNumberType(proposedValue, 0) ? proposedValue :
String("");

It’s more efficient to use emptyAtom here instead of String("").