[webkit-reviews] review granted: [Bug 55424] Stop using DeprecatedPtr for the global exception slot : [Attachment 84146] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 55424: Stop using DeprecatedPtr for the global exception slot
https://bugs.webkit.org/show_bug.cgi?id=55424

Attachment 84146: Patch
https://bugs.webkit.org/attachment.cgi?id=84146&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=84146&action=review

> Source/JavaScriptCore/runtime/WriteBarrier.h:154
> +template <typename T> class GCRootPtr : public WriteBarrierBase<T> {

I’ve been using:

    template<typename T>

without the space after template, by analogy with the lack of space after a
function name before its arguments. Just sayin’.

> Source/JavaScriptCore/runtime/WriteBarrier.h:159
> +	   this->setWithoutWriteBarrier(value);

Why all this use of this? Wouldn’t it compile without it?